镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

break nptables on block-level structures - #1617

Merged
joshbruce merged 4 commits into
markedjs:masterfrom
UziTech:following-nptable
Mar 17, 2020
Merged

joshbruce merged 4 commits into
markedjs:masterfrom
UziTech:following-nptable

Conversation

@UziTech

@UziTech UziTech commented Mar 9, 2020

Copy link
Copy Markdown
Member

Marked version: master

Markdown flavor: GitHub Flavored Markdown

Description

This PR copies #1598 to add breaking block-level rules to nptable (tables that don't start or end with a pipe)

e.g:

# nptable

 abc | def
 --- | ---
  1  |  2
  3  |  4

# table

| abc | def |
| --- | --- |
|  1  |  2  |
|  3  |  4  |

I also removed allowing setext header from breaking a table since it doesn't break on github. We can change it later easily if github changes. see #1598 (review)

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR).

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel

vercel Bot commented Mar 9, 2020 •

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/markedjs/markedjs/6rqwcwe36
✅ Preview: https://markedjs-git-fork-uzitech-following-nptable.markedjs.now.sh

Comment thread src/rules.js Resolved
Comment thread src/rules.js Resolved

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UziTech
UziTech requested review from davisjam and joshbruce March 9, 2020 22:25
@UziTech

UziTech commented Mar 17, 2020

Copy link
Copy Markdown
Member Author

@joshbruce could you review this so we can release v0.8.1

@UziTech UziTech mentioned this pull request Mar 17, 2020
11 of 12 tasks
@joshbruce

Copy link
Copy Markdown
Member

So glad to see all the tests.

tn0ms pushed a commit to warashibe/marked that referenced this pull request May 27, 2026
break nptables on block-level structures

This branch was successfully deployed

1 active deployment
Preview — 2d8045fe Deployed Mar 9, 2020 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants