镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Normalize tests - #1444

Merged
UziTech merged 12 commits into
markedjs:masterfrom
UziTech:normalize-tests
Mar 12, 2019
Merged

UziTech merged 12 commits into
markedjs:masterfrom
UziTech:normalize-tests

Conversation

@UziTech

@UziTech UziTech commented Mar 10, 2019

Copy link
Copy Markdown
Member

Marked version: master

Description

Normalize tests. Put non-spec tests into /new files.

New tests should be put into their own files so we don't have merge conflicts every time a PR with tests is merged.

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech

UziTech commented Mar 10, 2019 •

Copy link
Copy Markdown
Member Author

the tests will pass once #1439 is merged

Comment thread test/helpers/helpers.js Resolved
Comment thread test/specs/run-spec.js Resolved
Comment thread test/specs/run-spec.js Resolved
Comment thread test/specs/run-spec.js Resolved
Comment thread test/specs/run-spec.js Resolved
Comment thread test/helpers/helpers.js Resolved
@UziTech UziTech mentioned this pull request Mar 12, 2019
1 of 4 tasks
@UziTech
UziTech requested review from davisjam and joshbruce March 12, 2019 14:51

@davisjam davisjam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@UziTech
UziTech merged commit 5d6bde0 into markedjs:master Mar 12, 2019
@UziTech
UziTech deleted the normalize-tests branch March 12, 2019 17:05
@styfle styfle mentioned this pull request Mar 25, 2019
12 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants