镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix blockquote paragraph continuation - #1394

Merged
styfle merged 1 commit into
markedjs:masterfrom
mccraveiro:blockquote
Dec 20, 2018
Merged

styfle merged 1 commit into
markedjs:masterfrom
mccraveiro:blockquote

Conversation

@mccraveiro

@mccraveiro mccraveiro commented Dec 19, 2018 •

Copy link
Copy Markdown
Contributor

Marked version: master branch

Markdown flavor: CommonMark

Description

Input

> foo
    - bar

Expectation

<blockquote>
<p>foo
- bar</p>
</blockquote>

Result

<blockquote>
<p>foo</p>
<pre><code>- bar</code></pre></blockquote>

What was attempted

Fix blockquote paragraph continuation by limiting whitespaces before list item

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech

UziTech commented Dec 19, 2018

Copy link
Copy Markdown
Member

what is the input you are testing for the expected and actual output?

@mccraveiro

Copy link
Copy Markdown
Contributor Author

@UziTech I've updated the description with the actual input. Sorry :)

@UziTech UziTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep up the good work

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@styfle
styfle merged commit 2a9f782 into markedjs:master Dec 20, 2018
@mccraveiro
mccraveiro deleted the blockquote branch December 20, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants