镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Release 0.3.16 - #1067

Closed
joshbruce wants to merge 2 commits into
markedjs:masterfrom
joshbruce:master
Closed

joshbruce wants to merge 2 commits into
markedjs:masterfrom
joshbruce:master

Conversation

@joshbruce

@joshbruce joshbruce commented Feb 20, 2018 •

Copy link
Copy Markdown
Member

Submitter

  • $ npm version has been run.
  • Reviewer checklist is complete.
  • Merge PR.
  • Publish GitHub release using master with correct version number.
  • $ npm publish has been run.
  • Create draft GitHub release to prepare next release.

Reviewer

  • Version in package.json has been updated (see RELEASE.md).
  • The marked.min.js has been updated; or,
  • release does not change library.
  • All tests pass (remove once CI is in place).
  • All lint checks pass (remove once CI is in place).

@joshbruce

Copy link
Copy Markdown
Member Author

Want to make sure everyone can merge and confirm that this is what should be seen almost every time we do a release. Can last one to confirm do the merge? (Unless you think I broke something.)

Once merged I'll put the GitHub release package together.

@UziTech

UziTech commented Feb 20, 2018

Copy link
Copy Markdown
Member

I can see the big green button 👍

Should the min file have been updated in the same commit as the version?

@joshbruce

Copy link
Copy Markdown
Member Author

@UziTech: Yes. That's what doing it as a preversion gets us...both version and minification at the same time. Are you not seeing it?

screen shot 2018-02-20 at 3 34 09 pm

@styfle

styfle commented Feb 20, 2018

Copy link
Copy Markdown
Member

FYI, the link to RELEASE.md in your comment above is broken:

Version in package.json has been updated (see RELEASE.md).

@UziTech

UziTech commented Feb 20, 2018

Copy link
Copy Markdown
Member

@joshbruce I am seeing it in it's own commit: Run updated deployment sequence.

I thought it would be in the same commit as the version update 0.3.16

@joshbruce

Copy link
Copy Markdown
Member Author

Hmmm...fair. Could be the way the preversion hook works...??

  1. We run $ npm version
  2. NPM runs $ npm run preversion - creates the min file (does not commit)
  3. NPM update package.json - possibly commits??
  4. We commit in order to submit PR...ultimate (or final) commit??

Thoughts?

@joshbruce

Copy link
Copy Markdown
Member Author

@UziTech: I definitely did not create a commit with the 0.3.16 message; that's what's helping get me there.

@UziTech

UziTech commented Feb 20, 2018

Copy link
Copy Markdown
Member

Yup looks like npm only adds package.json and package-lock.json to the commit. I thought it would automatically add the min file too.

@UziTech

UziTech commented Feb 20, 2018 •

Copy link
Copy Markdown
Member

Maybe we should add an automatic commit after the build

"preversion": "npm run build && (git diff --quiet || git commit -am'minify')"

@joshbruce

Copy link
Copy Markdown
Member Author

@UziTech: Picking up on the adoption curves conversation from elsewhere (ES6), I prefer GitHub Desktop over Terminal. Never tried to do a push + PR without coming off the back-end of a commit I performed. So, not sure how explicit it will be for someone like me to know to do the PR after all things automated.

Willing to give it a shot though.

@joshbruce

Copy link
Copy Markdown
Member Author

Having said that, the latest version of GitHub Desktop doesn’t let you submit PRs directly from it anymore...so...there is that.

@joshbruce joshbruce changed the title Release 0.3.16 Release 0.3.17 Feb 25, 2018
@joshbruce joshbruce changed the title Release 0.3.17 Release 0.3.16 Feb 25, 2018
@joshbruce

Copy link
Copy Markdown
Member Author

see #1076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants