Repository navigation
Invisible proxy icon (AKA window title icon) #1503
Description
Steps to reproduce
Start without MacVim running.
open -a MacVim file.md.mvim file.mdalso works the same (I have a symlink tomvimin my PATH).- Observe the lack of the proxy icon.
Actually, the proxy icon still works if you know where to start dragging, but it is invisible.
Workaround (further adventure)
- Go to appearance settings
- Check "Hidden title bar" and uncheck it again
- The proxy icon is visible now.
Expected behaviour
The proxy icon should be visible regardless.
Version of Vim and architecture
MacVim r180, Vim 9.1.727, ARM, on
Environment
Sonoma 14.7
I'm using the dark theme for it. Somewhere in Apple's Settings, I also selected the option to make it show the proxy icons without having to click on the title first. Update: I mean the "Apple Settings -> Display -> Show window title icons" option.
How MacVim was installed
From GitHub
Logs and stack traces
No response
Vim configuration where issue is reproducable
No response
Issue has been tested with given configuration
- by running MacVim.app from GUI macOS interface
- by running vim/gvim/etc installed by MacVim
- by running other versions of vim (e.g. /usr/bin/vim)
Issue has been tested with no configuration
- by running
mvim --clean(orgvim, supplied by MacVim distribution) - by running
vim --clean(in terminal, supplied by MacVim distribution) - by running
vim --clean(in terminal, other suppliers, e.g. /usr/bin/vim)
Other conditions
- The both Homebrew packages "vim" and "macvim" are installed
Activity
[-]Invisible proxy icon[/-][+]Invisible proxy icon (AKA window title icon)[/+]ychin commentedon Oct 17, 2024
This was actually done intentionally when I implemented #1038. It isn't really a bug as I just thought this looks cleaner, but in retrospect providing an option to show file name or not might have been the easier / cleaner solution.
Was the motivation for this issue post entirely for the ripdrag linked issue? I was curious what you use the icon for.
ilyagr commentedon Oct 17, 2024
I would currently mainly use it for that, yes. I may or may not open the file only to drag it.
It feels like a bug that toggling the "hide window bar" option changes the look.
By default, Mac OS Sonoma hides the icon until you click on the window title. I'm not sure how easy that is, but ideally you'd follow that behavior and respect the "show window icons" system option for people who want to avoid that click.
ychin commentedon Oct 17, 2024
Yeah I think having a separate option properly makes more sense. Sometimes trying to be too smart is detrimental to having a consistent setting. I'll put this to backlog.
I think this only applies to the combined toolbar mode. For example, Finder and Preview does that, but TextEdit doesn't.
In fact, MacVim also does that if you use the toolbar as well (
:set go+=T). Either way it wouldn't affect our decision here.WIP document icon add back for transparent, and make customizable
Add setting for whether to show document icon at title bar
Add setting for whether to show document icon at title bar
Add setting for whether to show document icon at title bar