镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Update from tools.deps.alpha #10

Open

Description

@patbrown

I don't know exactly what the deal is with tools.deps and tools.deps.alpha. My knowledge of their inner-workings is limited. But classpath is reliant on create-basis slurp-deps from tools.deps.alpha. Do you want to upgrade? If so, would you like a PR?

I only ask because I really have no idea what a prudent plan around transitioning looks like. Both functions are present and the PR wouldn't take me much time, but if updating breaks other things you've got going on or your users I don't want to bother with it. I'm using both deps and deps.alpha via a hacky deps.edn trick for the time being.

Throughout the years I've enjoyed learning with your videos, episode 32 really changed how I treated metadata. And Classpath is an important tool in my dev workflow, so... THANKS FOR THAT!

Activity

  1. plexus commented on Jun 27, 2023

    @plexus
    Member

    Hey, happy to hear you've enjoyed the videos!

    To be honest I'm not sure, until someone does a deep dive to compare the two approaches it's hard to say how we could benefit from the work there.

    If I had to guess I'd say we're a bit more aggressive in setting up or replacing classloaders, and we have logic to make sure upgraded dependencies get precedence over the old versions. I wouldn't expect a core library to do that kind of shenanigans.

    So unless someone can make a compelling technical case I think we default to doing nothing. The current approach will continue to work.

    The nature of this classpath stuff is that it's not too hard to get working in general, but there are almost always edge cases in particular when interacting with other tools and libraries, so I think it's good to have multiple options with different approaches. People can pick what's must appropriate for them.

  2. plexus commented on Jun 27, 2023

    @plexus
    Member

    That said a simple version bump would be fine, if that does break things then it's better to find out.

  3. alysbrooks commented on Jul 11, 2023

    @alysbrooks
    Member

    Hi @patbrown, no big rush, but would you be interested in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions