镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

main doesn't build since #141: CA1506 fails RunCommand.Test (RunCommandTests coupled with 98 types, limit 96), so CI is red and none of the recent fixes can release #152

Open

Description

@matt-edmondson

What's wrong

On main (9e8ed93), dotnet build RunCommand.Test fails with:

RunCommandTests.cs(13,14): error CA1506: 'RunCommandTests' is coupled with '98' different types from '27' different namespaces. Rewrite or refactor the code to decrease its class coupling below '96'.

Suggested fix

Split RunCommandTests into a few classes by area: overlay PATH resolution, cancellation and process-tree kill, working directory, and output decoding (BOM, CR). The tests are already grouped that way, and splitting them brings each class well under the coupling limit. CLAUDE.md rules out global suppressions.

Acceptance criteria

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions