Repository navigation
Write no namespace line for a whitespace-only namespace [patch] - #204
Open
matt-edmondson wants to merge 1 commit into
Open
matt-edmondson wants to merge 1 commit into
matt-edmondson wants to merge 1 commit into
Conversation
WriteFileScopedNamespace checked IsNullOrEmpty, so SourceFileTemplate.Namespace = " " wrote 'namespace ;' (CS1001). Blank usings, attributes and list entries are already skipped with IsNullOrWhiteSpace; the namespace now matches. Fixes #203 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW5YjyP4TWYsDuKLv95
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203
What was wrong
WriteFileScopedNamespaceskipped only a null or empty namespace.SourceFileTemplate { Namespace = " " }wrotenamespace ;, which fails with CS1001. Blank usings, attributes and list entries were already skipped withIsNullOrWhiteSpace(#189, #191, #200).Change
CodeBlockerExtensions.WriteFileScopedNamespacenow usesstring.IsNullOrWhiteSpace, so a whitespace-only namespace writes nothing, the same as"".WriteFileScopedNamespaceandSourceFileTemplate.Namespacenow say that whitespace counts as no namespace.Tests
AWhitespaceNamespaceWritesNothing(" "and"\t"through the extension).ASourceFileWithAWhitespaceNamespaceWritesNoNamespace. This is the issue's repro:Namespace = " "plus a blank using writes onlyusing System;.Generated by Claude Code