Repository navigation
Remove obsolete, lying "engines" field from package.json - #717
Merged
Merged
Conversation
This has been wrong since AT LEAST back when we started using Intl.Segmenter in diffWords, since Segmenter support was only added to Node in v16. Honestly I just never noticed this field in package.json since I took over maintainership or thought about whether it was correct until a Copilot review in #710 made reference to it. It'd be nice to replace it with a CORRECT constraint instead of just eliminating it, but annoyingly that's nontrivial. I can't just try running the test suite in difference versions of Node to see which ones it passes on because the dev packages needed to RUN THE TEST SUITE require at least Node v22 (which I suspect is a much later version than is truly needed just to support jsdiff itself). In the absence of knowing what the truth is, or how to find out, simply deleting the false claim and saying nothing is surely better than the status quo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been wrong since AT LEAST back when we started using Intl.Segmenter in diffWords, since Segmenter support was only added to Node in v16. Honestly I just never noticed this field in package.json since I took over maintainership or thought about whether it was correct until a Copilot review in #710 made reference to it.
It'd be nice to replace it with a CORRECT constraint instead of just eliminating it, but annoyingly that's nontrivial. I can't just try running the test suite in difference versions of Node to see which ones it passes on because the dev packages needed to RUN THE TEST SUITE require at least Node v22 (which I suspect is a much later version than is truly needed just to support jsdiff itself).
In the absence of knowing what the truth is, or how to find out, simply deleting the false claim and saying nothing is surely better than the status quo.
(Note also that in the README we only claim to support the latest LTS version of Node; this vastly stronger claim was inconsistent with that.)