镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix zip deflate - #234

Open
zapu wants to merge 1 commit into
keybase:masterfrom
zapu:fix-zip-deflate
Open

zapu wants to merge 1 commit into
keybase:masterfrom
zapu:fix-zip-deflate

Conversation

@zapu

@zapu zapu commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

This is part of the effort to clean up obvious runtime errors due to undefined references. ZIP deflate had a typo in the function name, but that code path was not exercised, and it didn't work anyway. Fix was trivial so I've just done it, exposed compression algo setting in Burner, and added roundtrip tests for different compression settings as well as invalid setting.

NOTE: OpenPGP ZIP compression is a raw DEFLATE stream, without zlib
headers.

Fixed an undefined reference to `fake_zip_deflate`, presumably the
function had a typo in the name. Added a way to specify the compression
algo in `burn` API so it's available to the end users and we can also
test it end to end. Added roundtrip tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant