Repository navigation
Drop use of deprecated APIs from JRuby #346
Description
Activity
🔍 Code Quality Analysis
Hi! I noticed this issue and ran an automated code quality scan on jruby/jruby-openssl.
📊 Scan Results
- Overall Score: 35/100 (Grade: F)
- Total Issues Found: 820
🔴 Top Issues
- WARNING: java.util.Date is largely deprecated in favor of java.time API
- File:
main/java/org/jruby/ext/openssl/OCSPBasicResponse.java:340
- File:
- WARNING: java.util.Date is largely deprecated in favor of java.time API
- File:
main/java/org/jruby/ext/openssl/OCSPBasicResponse.java:340
- File:
- WARNING: java.util.Date is largely deprecated in favor of java.time API
- File:
main/java/org/jruby/ext/openssl/OCSPBasicResponse.java:340
- File:
- WARNING: java.util.Date is largely deprecated in favor of java.time API
- File:
main/java/org/jruby/ext/openssl/OCSPSingleResponse.java:272
- File:
- WARNING: java.util.Date is largely deprecated in favor of java.time API
- File:
main/java/org/jruby/ext/openssl/OCSPSingleResponse.java:273
- File:
📋 Additional Issues Found
Besides the primary issues, I also found:
- 344 Context Coherence issues
- 454 Implementation issues
These may impact overall code quality and maintainability.
💡 Recommendation: Consider addressing these issues alongside the original problem to improve overall code health.
🛠️ Recommended Actions
-
For Code Freshness issues:
- Review the detailed report for specific guidance
- Address high-severity issues first
- Run another scan after fixes to verify
-
Get detailed HTML report:
npx @opencodereview/cli scan jruby/jruby-openssl --format html --output report.html
-
Fix systematically:
- Review the HTML report for detailed code snippets
- Address issues by severity (high → medium → low)
- Re-run scan after fixes to verify improvements
This is an automated scan from Open Code Review — a free, open-source code quality tool. If this isn't helpful, feel free to ignore or delete this comment.
Scanned on 2026-03-12
In jruby/jruby#9299 I attempted to remove all APIs deprecated prior to the release of JRuby 9.4.0.0, knowing that there would be some third-party libraries that still accessed them. jruby-openssl was a cuplrit for several:
nameand a few "pre" methods for framing. This is due to the generation being run on an older version of JRuby. jruby/jruby@2dd94edBlockingTaskAPI for interrupting blocking operations, which has been replaced in the last few major JRuby releases. jruby/jruby@c086c7aWe should try to eliminate these uses while still considering how far back we want to support old JRuby releases.