Repository navigation
Fix failing unit test test.cxx.isce3.io.raster.raster - #348
Merged
Merged
Conversation
Contributor
Author
|
Okay, looks like I found it. The unit test was only initializing the first 100 rows of a raster and then trying to read 200 rows in another test. I guess some update in GDAL now triggers a failure in that case. It's easy to fix the tests by just initializing the full raster. I added a few extra test assertions for good measure. |
Tyler-g-hudson
added a commit
that referenced
this pull request
Aug 20, 2026
commit fc8112c Author: xhuang-jpl <118782850+xhuang-jpl@users.noreply.github.com> Date: Thu Aug 20 11:35:37 2026 -0700 Update Soil Moisture SAS to v0.4.3 (#349) * sm r3.4 * change the SM commit id for R4.0.2 * update the SM SAS version to v0.4.3 --------- Co-authored-by: Xiaodong Huang <xhuang@nisar-adt-dev-3.jpl.nasa.gov> commit 0d1600d Author: SamNemo <11642807+nemo794@users.noreply.github.com> Date: Mon Aug 17 16:19:06 2026 -0700 Update STATIC workflow for new water mask spec (#334) * Update STATIC workflow for new water mask spec. * Update STATIC runconfig with explicit classification values for water mask --------- Co-authored-by: Samantha C. Niemoeller <samantha.c.niemoeller@jpl.nasa.gov> commit be7b3d9 Author: Brian Hawkins <1729052+bhawkins@users.noreply.github.com> Date: Thu Aug 13 18:13:07 2026 -0500 Fix failing unit test test.cxx.isce3.io.raster.raster (#348) * Check raster dimensions * Initialize all rows in mask file. commit 0a8df45 Author: Tyler G. Hudson <tyler.g.hudson@gmail.com> Date: Tue Aug 11 17:25:18 2026 -0700 Remove pyproj Dependency to Resolve conda-forge Feedstock Issues (#339) * Remove dead code in llhxyz.py that depends on pyproj * Update reprojection code in unwrap/preprocess.py commit 54f2c28 Author: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> Date: Thu Jun 25 23:50:55 2026 -0700 Add radar grid decimation option to compute the static layers layover/shadow mask (#328) * disable polarimetric symmetrization by default * revert changes to `symmetrize_cross_pol_channels` * Update GCOV and GSLC specification XMLs * Revert changes to the GCOV and GSLC specification XMLs * add radargrid decimation option to compute the layover shadow mask * simplify parameter names
sharath-velishala
added a commit
to A-Science-Company/isce3
that referenced
this pull request
Sep 3, 2026
Brings in 5 upstream commits from isce-framework/isce3. None touch asc/, so no conflict with our work. f42cea7 Use optimized HDF5 reader for resample_slc_v2 (isce-framework#372) 23f9932 Solve CI failures (isce-framework#366) fc8112c Update Soil Moisture SAS to v0.4.3 (isce-framework#349) 0d1600d Update STATIC workflow for new water mask spec (isce-framework#334) be7b3d9 Fix failing unit test test.cxx.isce3.io.raster.raster (isce-framework#348) Note these change the FORK's source only. We run isce3 0.25.12 from conda-forge and never build this tree, so none of them affect our runtime -- including isce-framework#372, which touches the resample_slc_v2 that Track R will use. That optimisation lands for us only when conda-forge ships a release containing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will attempt to fix the failing unit test
test.cxx.isce3.io.raster.raster. I noticed it on another PR, but I think it's unrelated to those changes. I think I know what the problem is but want to reproduce the CI failure before pushing a fix.