Repository navigation
fix(searchbar): forward aria-label and aria-labelledby from host to input - #31595
Open
rudrakshagarwal4200-ai wants to merge 1 commit into
Open
rudrakshagarwal4200-ai wants to merge 1 commit into
rudrakshagarwal4200-ai wants to merge 1 commit into
Conversation
|
@rudrakshagarwal4200-ai is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #31492.
ion-searchbarpreviously hardcodedaria-label="search text"on its native<input>element and only inherited['lang', 'dir']from the host. As a result, customaria-labeloraria-labelledbyattributes placed on<ion-searchbar>were never forwarded to the input, causing screen readers to announce "search text" unconditionally regardless of app localization or search context.Fix
componentWillLoad(), merge...inheritAriaAttributes(this.el)intothis.inheritedAttributesso thataria-labelandaria-labelledbyare forwarded to the native input, consistent withion-inputandion-textarea.aria-label="search text"as the default fallback whenaria-labelledbyis not set on the host, while allowing hostaria-label(via spread) oraria-labelledbyto take precedence.