Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OS-jacobbell
approved these changes
May 15, 2026
OS-jacobbell
left a comment
Contributor
There was a problem hiding this comment.
Makes sense, good find!
3 tasks done
1 of 2 tasks
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-ionic-team__ionic-framework
that referenced
this pull request
Oct 20, 2026
…nic-team#31583) Issue number: resolves ionic-team#30617 --------- ## What is the current behavior? Currently, replacing a page inside a tab stack breaks going back in two different ways. Calling `useIonRouter().replace()` shows a back button that does nothing, because `replace()` sends the `root` direction, which clears the location history but leaves `pushedByRoute` set. Calling `navigate(path, 'forward', 'replace')` after switching tabs does the opposite, so the URL goes back but the replaced page stays on screen. That one happens because the back button calls `router.go(-3)` and the router assumes the page we left is only one entry ahead. ## What is the new behavior? Now `replace()` uses the `none` direction, so it keeps the pages beneath the one it replaced and still doesn't animate, the same as a plain `router.replace()`. The router also uses the real history delta to find the page we left, and an explicit `navigate(url, 'root', 'replace')` no longer shows a back button since there's nothing to go back to. ## Does this introduce a breaking change? - [ ] Yes - [X] No ## Other information This does change `replace()` for apps that relied on it clearing the history. That only started in 9.0, when ionic-team#31142 made the router respect the caller's direction, and those apps can switch to `navigate(url, 'root', 'replace')`. I updated the `useIonRouter` docs in ionic-docs to match here: ionic-team/ionic-docs#4794
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #24995
What is the current behavior?
In
createIonRouter, the replace-action branch resolvesrouteInfo.routerDirectionandrouteInfo.routerAnimationby preferring the leaving route's values over the ones the caller passed in. The leaving route wins whenever it has any value set, souseIonRouter.navigate(url, 'forward', 'replace')called after a back navigation ends up withrouterDirection: 'back', and the same call from the initial route ends up with'none'. The caller's explicit direction is silently discarded.What is the new behavior?
The precedence is flipped: the caller's
routerDirectionandrouterAnimationare kept, and the leaving route's values are only used as a fallback when nothing was provided.forward + replacenow animates forward regardless of how the user got to the leaving page, and the defaultuseIonRouter.replace(url)keeps the'root'direction it was constructed with instead of inheriting whatever the leaving route had recorded.Does this introduce a breaking change?
Other information