Repository navigation
fix build with GCC 16.2 - #397
Merged
Merged
Conversation
Fixing this error when building with GCC 16.2:
error: ‘mutex’ in namespace ‘std’ does not name a type
187 | inline static std::mutex mutex_{};
ethanglaser
approved these changes
Oct 5, 2026
ethanglaser
left a comment
Member
There was a problem hiding this comment.
Thanks for opening this, I reproduced and verified the fix locally. LGTM, we can merge this after #382
|
Tick the box to add this pull request to the merge queue (same as
|
This was referenced Nov 1, 2026
alonre24
added a commit
to RedisAI/VectorSimilarity
that referenced
this pull request
Nov 1, 2026
SVS v0.5.0's svs/core/allocator.h uses std::mutex without including <mutex>, which GCC 16's libstdc++ no longer provides transitively. Advance the submodule by the single upstream fix commit on top of v0.5.0 (intel/ScalableVectorSearch#397). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
alonre24
added a commit
to RediSearch/RediSearch
that referenced
this pull request
Nov 1, 2026
Pick up the SVS submodule bump that adds the missing <mutex> include to svs/core/allocator.h (intel/ScalableVectorSearch#397). Without it, compiling SVS from source fails under GCC 16. The new pin is on VecSim's 8.12 branch: its content matches the previous pin apart from the SVS bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alonre24
added a commit
to RediSearch/RediSearch
that referenced
this pull request
Nov 1, 2026
Pick up the SVS submodule bump that adds the missing <mutex> include to svs/core/allocator.h (intel/ScalableVectorSearch#397). Without it, compiling SVS from source fails under GCC 16. The new pin is on VecSim's 8.12 branch: its content matches the previous pin apart from the SVS bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alonre24
added a commit
to RediSearch/RediSearch
that referenced
this pull request
Nov 1, 2026
Pick up the SVS submodule bump that adds the missing <mutex> include to svs/core/allocator.h (intel/ScalableVectorSearch#397). Without it, compiling SVS from source fails under GCC 16. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alonre24
added a commit
to RediSearch/RediSearch
that referenced
this pull request
Nov 1, 2026
* [8.12] [MOD-20661] Bump VecSim to fix the build with GCC 16 Pick up the SVS submodule bump that adds the missing <mutex> include to svs/core/allocator.h (intel/ScalableVectorSearch#397). Without it, compiling SVS from source fails under GCC 16. The new pin is on VecSim's 8.12 branch: its content matches the previous pin apart from the SVS bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * [8.12] [MOD-20661] Pin VecSim to the merged GCC 16 fix Point the submodule at the commit RedisAI/VectorSimilarity#1091 merged as on VecSim's 8.12 branch, in place of that PR's head. The content is the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
aradalvand
pushed a commit
to aradalvand/RediSearch
that referenced
this pull request
Nov 2, 2026
* [MOD-20661] Bump VecSim to fix the build with GCC 16 Pick up the SVS submodule bump that adds the missing <mutex> include to svs/core/allocator.h (intel/ScalableVectorSearch#397). Without it, compiling SVS from source fails under GCC 16. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * [MOD-20661] Build and test on Arch Linux in the nightly Arch is a rolling release, so it ships new toolchains first. The GCC 16 build break in SVS reached us from an Arch packager at RC time; a nightly Arch job would have flagged it as soon as Arch moved to GCC 16. archlinux:latest is an explicit-only platform (x86_64, the only arch the official image supports), so it stays out of "all" and PR CI. It builds SVS from the submodule, like Arch packages do, rather than from the prebuilt SVS tarball the other platforms use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ethanglaser
added a commit
that referenced
this pull request
Nov 2, 2026
Fixing this error when building with GCC 16.2:
```
error: ‘mutex’ in namespace ‘std’ does not name a type
187 | inline static std::mutex mutex_{};
```
Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing this error when building with GCC 16.2: