Repository navigation
Conversation
Member
|
We seem to need to update the CI workflows - would you like to handle this? |
Author
|
Yes, happy to handle the CI workflow updates. I’ll take a look at the failing workflow and update it as part of this PR. |
Author
|
Yes, I believe they address the same CLI issue. I've already fixed the decompression CLI bug in #154, added regression tests, and pushed an additional fix for the failing sdist CI workflow. Could you please take a look at #154? It includes both the CLI fix and the CI workflow correction. Happy to make any further changes if needed. |
Member
|
The CI runs may not be starting because they need old versions of the OS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
python -m snappy -draises:TypeError: cannot unpack non-iterable function object
This happens because
get_decompress_function()now returns a single decompression function, while the CLI still tries to unpack it intomethodandread_chunk.Fix
Update the CLI to use the current single-value return API and remove the obsolete
start_chunkargument.Tests
get_decompress_function()python -m snappy -d