镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Parse mentions in text - #197

Merged
rmccue merged 10 commits into
masterfrom
mentions-in-text
Jul 26, 2018
Merged

rmccue merged 10 commits into
masterfrom
mentions-in-text

Conversation

@rmccue

@rmccue rmccue commented Apr 18, 2018

Copy link
Copy Markdown
Member

Fixes #158.

@hm-linter hm-linter Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (4 errors).

Comment thread src/components/Message/Mention.js Outdated
}
}

Mention.propTypes = {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break after this opening brace.

Comment thread src/components/Message/Mention.js Outdated

Mention.propTypes = {
user: PropTypes.object,
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break before this closing brace.

Comment thread src/components/Message/Mention.js Outdated

match( string ) {
return this.doMatch( string, /@(\w+)/, matches => {
return {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break after this opening brace.

Comment thread src/components/Message/Mention.js Outdated
return this.doMatch( string, /@(\w+)/, matches => {
return {
username: matches[1],
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break before this closing brace.

@hm-linter hm-linter Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting successful, all issues fixed! 🎉

@rmccue

rmccue commented Apr 23, 2018

Copy link
Copy Markdown
Member Author

I'm not yet confident of the HTML parsing aspect of Interweave, so want to do some more trials on real content first.

@joehoyle

Copy link
Copy Markdown
Member

Woop woop! Been waiting for this one for a while!

Comment thread src/components/Message/Mention.js Outdated

export default ConnectedMention;

export class MentionMatcher extends Matcher {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not wild about this not following the component per file. I get it's not a component, but still feels like in that case it shoudln't be in the Components dir.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 663c2d2

@hm-linter hm-linter Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting successful, all issues fixed! 🎉

@hm-linter hm-linter Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (1 error).

  • Introduced 1 new error

@hm-linter hm-linter Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting successful, all issues fixed! 🎉

@rmccue
rmccue merged commit 4448b8d into master Jul 26, 2018
@rmccue rmccue mentioned this pull request Jul 29, 2018
@rmccue
rmccue deleted the mentions-in-text branch August 22, 2018 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants