Repository navigation
fix(canvas): let sticky note editors scroll their own text - #59
Merged
howdeploy merged 1 commit intoSep 26, 2026
Merged
Conversation
This was referenced Sep 23, 2026
BIackFIame
added a commit
to BIackFIame/CanvasTTY
that referenced
this pull request
Sep 23, 2026
BIackFIame
added a commit
to BIackFIame/CanvasTTY
that referenced
this pull request
Sep 23, 2026
BIackFIame
added a commit
to BIackFIame/CanvasTTY
that referenced
this pull request
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long sticky notes cannot be scrolled normally because the canvas wheel handler claims the editor's wheel event. The note card had local wheel ownership, but no priority-local marker for the editor.
This gives the editor local wheel priority while keeping wheel navigation over the note header and canvas background. A regression drives the production wheel router and checks ownership,
preventDefault, propagation, and canvas navigation for all three targets.Validation: 12 focused wheel/note tests, 659/659 full project tests, TypeScript typecheck, and
git diff --checkpass. Visual Electron interaction remains untested; no live app was restarted.