镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Add Base64 scalar - #1221

Merged
syrusakbary merged 1 commit into
graphql-python:masterfrom
EpicEric:base64
Jul 2, 2020
Merged

syrusakbary merged 1 commit into
graphql-python:masterfrom
EpicEric:base64

Conversation

@EpicEric

@EpicEric EpicEric commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@jkimbo jkimbo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thanks @EpicEric ! Added a couple of minor comments.

Comment thread graphene/types/base64.py Outdated
Comment thread graphene/types/tests/test_base64.py Outdated
@jkimbo
jkimbo self-requested a review July 2, 2020 14:47

@jkimbo jkimbo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants