Update dataloader docs to use aiodataloader #1189

Activity

1. jkimbo

   added

   ✨ enhancement

   3.0Fix/Release version 3.0Fix/Release version 3.0

   on Apr 26, 2020
2. jkimbo

   self-assigned this

   on Apr 26, 2020
3. jkimbo

   changed the title [-]Implement asyncio version of dataloader[/-] [+]Update dataloader docs to use aiodataloader[/+] on Apr 26, 2020
4. jkimbo

   added

   📖 documentation

   and removed

   ✨ enhancement

   on Apr 26, 2020
5. nerdstrike commented on May 27, 2020

   

   nerdstrike

   on May 27, 2020

   More actions

   Just to note that aiodataloader seems to be unmaintained at this time. I put in a request to remove a deprecated python import months ago and it has gone neglected.
6. jkimbo

   removed their assignment

   on Nov 11, 2020
7. asia653 commented on Oct 25, 2021

   

   asia653

   on Oct 25, 2021

   More actions

   user1_future = user_loader.load(1)
   user2_future = user_loader.load(2)
   
   user1 = await user1_future
   user2 = await user2_future
   
   user1_invitedby = user_loader.load(user1.invited_by_id)
   user2_invitedby = user_loader.load(user2.invited_by_id)
   
   print("User 1 was invited by", await user1_invitedby)
   print("User 2 was invited by", await user2_invitedby)
   
   

   Is this code in the docs correct? According to the codebase, dataloader returns a Promise that resolves into an array of values, so awaiting the future should return an array with a single value
8. cpmsmith commented on Apr 18, 2022

   

   cpmsmith

   on Apr 18, 2022

   More actions

   Just to note that aiodataloader seems to be unmaintained at this time. I put in a request to remove a deprecated python import months ago and it has gone neglected.

   Note to onlookers: the PR mentioned here, syrusakbary/aiodataloader#11, has since been merged, and aiodataloader released a version on 2022-01-24.

   👍React with 👍2Reacted by Kieron Taylor and Elephant Liu
9. erikwrede

   closed this as completedin #1190on Aug 13, 2022