Repository navigation
fix(afc): guard type argument unpacking for unsubscripted typing.List and typing.Dict in convert_if_exist_pydantic_model - #3045
Open
chauvuusvn wants to merge 1 commit into
Conversation
… and typing.Dict in convert_if_exist_pydantic_model
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3044
In
convert_if_exist_pydantic_model, unsubscripted generic type annotations liketyping.Listortyping.DictcausedIndexErrororValueErrorwhen attempting to unpack emptyget_args(annotation)tuples during Automatic Function Calling (AFC).Changes
get_args(annotation)forlistorigins before indexing[0].get_args(annotation)fordictorigins to requirelen(args) == 2before unpacking key/value types.google/genai/tests/afc/test_convert_if_exist_pydantic_model.pyverifying thattyping.Listandtyping.Dictconvert cleanly without exceptions.Author: Chau Vu / CPF-FAMILY (@chauvuusvn)