Repository navigation
fix(gapic-generator): do not emit empty routing metadata on client-streaming RPCs - #18591
Open
daniel-sanche wants to merge 2 commits into
Open
daniel-sanche wants to merge 2 commits into
daniel-sanche wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request prevents the generation of routing metadata headers for client streaming and bidirectional streaming RPC methods in Python GAPIC clients. It updates Jinja2 templates (both standard and ads-specific) to conditionally skip metadata generation when method.client_streaming is true. It also adds streaming methods to test proto definitions and introduces a comprehensive unit test to verify this behavior. I have no feedback to provide as there are no review comments.
daniel-sanche
marked this pull request as ready for review
October 7, 2026 03:11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the generator would output empty routing metadata for client-streaming RPCs. Instead, we should skip adding routing metadata altogether when
client_streamingis true.Addresses #16650 (will be fixed after next generator update)