feat(crc32c): free-threading support

packages/google-crc32c/pyproject.toml

@@ -13,7 +13,7 @@
 # limitations under the License.
 
 [build-system]
-requires = ["setuptools", "wheel"]
+requires = ["setuptools >= 77.0.3"]
 build-backend = "setuptools.build_meta"
 
 [project]
@@ -22,5 +22,26 @@ version = "1.9.0"
 description = "A python wrapper of the C library 'Google CRC32C'"
 readme = "README.md"
 requires-python = ">=3.10"
-license = {text = "Apache-2.0"}
-dynamic = ["classifiers"]
+authors = [{name = "Google LLC", email = "googleapis-packages@google.com"}]
+urls = {Homepage = "https://github.com/googleapis/google-cloud-python/tree/main/packages/google-crc32c"}
+optional-dependencies = {testing = ["pytest"]}
+license = "Apache-2.0"
+license-files = ["LICENSE"]
+classifiers = [
+    "Development Status :: 4 - Beta",
+    "Intended Audience :: Developers",
+    "Operating System :: OS Independent",
+    "Programming Language :: Python :: 3",
+    "Programming Language :: Python :: 3.10",
+    "Programming Language :: Python :: 3.11",
+    "Programming Language :: Python :: 3.12",
+    "Programming Language :: Python :: 3.13",
+    "Programming Language :: Python :: 3.14",
+    "Programming Language :: Python :: 3.15",
+]
+
+[tool.setuptools]
+include-package-data = false
+package-data = {google_crc32c = ["py.typed"]}
+platforms = ["Posix", "MacOS X", "Windows"]
+zip-safe = true

packages/google-crc32c/src/google_crc32c/_crc32c.c

@@ -5,36 +5,30 @@
 /* The minimum buffer size in bytes (1MB) required to justify the overhead of releasing the GIL. */
 static const Py_ssize_t gil_threshold = 1024 * 1024;
 
-static int
-_should_release_gil(Py_ssize_t length, PyObject *chunk_obj)
-{
-    /* Checks if the chunk is immutable (bytes) to prevent concurrent modification,
-     * and large enough to benefit from releasing the GIL. */
-    return (length >= gil_threshold && PyBytes_Check(chunk_obj));
-}
 
 static PyObject *
 _crc32c_extend(PyObject *self, PyObject *args)
 {
     unsigned long crc_input;
     uint32_t crc;
-    const char *chunk;
-    Py_ssize_t length;
     PyThreadState *save = NULL;
+    Py_buffer buffer;
 
-    if (!PyArg_ParseTuple(args, "ky#", &crc_input, &chunk, &length))
+    if (!PyArg_ParseTuple(args, "ky*", &crc_input, &buffer))
         return NULL;
 
-    if (_should_release_gil(length, PyTuple_GET_ITEM(args, 1))) {
+    if (buffer.len >= gil_threshold) {
         save = PyEval_SaveThread();
     }
 
-    crc = crc32c_extend((uint32_t)crc_input, (const uint8_t*)chunk, length);
+    crc = crc32c_extend((uint32_t)crc_input, (const uint8_t*)buffer.buf, buffer.len);
 
     if (save) {
         PyEval_RestoreThread(save);
     }
 
+    PyBuffer_Release(&buffer);
+
     return PyLong_FromUnsignedLong(crc);
 }
 
@@ -43,23 +37,24 @@ static PyObject *
 _crc32c_value(PyObject *self, PyObject *args)
 {
     uint32_t crc;
-    const char *chunk;
-    Py_ssize_t length;
+    Py_buffer buffer;
     PyThreadState *save = NULL;
 
-    if (!PyArg_ParseTuple(args, "y#", &chunk, &length))
+    if (!PyArg_ParseTuple(args, "y*", &buffer))
         return NULL;
 
-    if (_should_release_gil(length, PyTuple_GET_ITEM(args, 0))) {
+    if (buffer.len >= gil_threshold) {
         save = PyEval_SaveThread();
     }
 
-    crc = crc32c_value((const uint8_t*)chunk, length);
+    crc = crc32c_value((const uint8_t*)buffer.buf, buffer.len);
 
     if (save) {
         PyEval_RestoreThread(save);
     }
 
+    PyBuffer_Release(&buffer);
+
     return PyLong_FromUnsignedLong(crc);
 }
 
@@ -72,19 +67,59 @@ static PyMethodDef Crc32cMethods[] = {
     {NULL, NULL, 0, NULL}        /* Sentinel */
 };
 
+#if PY_VERSION_HEX >= 0x030f0000
+PyABIInfo_VAR(abi_info);
+static PySlot Crc32cSlots[] = {
+    PySlot_STATIC_DATA(Py_mod_abi, &abi_info),
+    PySlot_STATIC_DATA(Py_mod_name, "_crc32c"),
+    PySlot_STATIC_DATA(Py_mod_methods, Crc32cMethods),
+    PySlot_SIZE(Py_mod_state_size, 0),
+    PySlot_UINT64(Py_mod_multiple_interpreters, Py_MOD_PER_INTERPRETER_GIL_SUPPORTED),
+    PySlot_UINT64(Py_mod_gil, Py_MOD_GIL_NOT_USED),
+    PySlot_END
+};
 
-static struct PyModuleDef crc32cmodule = {
-    PyModuleDef_HEAD_INIT,
-    "_crc32c",   /* name of module */
-    NULL, /* module documentation, may be NULL */
-    -1,       /* size of per-interpreter state of the module,
-                 or -1 if the module keeps state in global variables. */
-    Crc32cMethods
+PyMODEXPORT_FUNC
+PyModExport__crc32c()
+{
+    return Crc32cSlots;
+}
+
+PyMODINIT_FUNC
+PyInit__crc32c(void)
+{
+    /* workaround for setuptools on Python 3.15+ */
+    /* https://github.com/pypa/distutils/issues/387 */
+    return NULL;
+}
+
+#else
+
+static PyModuleDef_Slot Crc32cSlots[] = {
+#ifdef Py_mod_multiple_interpreters
+    {Py_mod_multiple_interpreters, Py_MOD_PER_INTERPRETER_GIL_SUPPORTED},
+#endif
+#ifdef Py_mod_gil
+    {Py_mod_gil, Py_MOD_GIL_NOT_USED},
+#endif
+    {0, NULL}
 };
 
+static struct PyModuleDef crc32cmodule = {
+    PyModuleDef_HEAD_INIT, /* m_base */
+    "_crc32c",             /* m_name: name of module */
+    NULL,                  /* m_doc: module documentation, may be NULL */
+    0,                     /* m_size: size of per-interpreter state of the module */
+    Crc32cMethods,         /* m_methods */
+    Crc32cSlots,           /* m_slots */
+    NULL,                  /* m_traverse */
+    NULL,                  /* m_clear */
+    NULL,                  /* m_free */
+};
 
 PyMODINIT_FUNC
 PyInit__crc32c(void)
 {
-    return PyModule_Create(&crc32cmodule);
+    return PyModuleDef_Init(&crc32cmodule);
 }
+#endif