Repository navigation
test_sync_query_w_dml has num_dml_affected_rows unset #3742
Description
See: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2753
@tswast Any idea what would cause this "flake" to happen? (Note that the 2.7 system tests in the same build did not have this failure, as well as every other time this test case has run on CI.)
Activity
tswast commentedon Aug 7, 2017
Bah! No clue. I wish we logged the Job ID so that I could pass it on to the backend team to investigate further.
dhermes commentedon Aug 7, 2017
Are the job IDs generated by the client? If yes, they probably match some specific regex with the build ID in it.
tswast commentedon Aug 7, 2017
They are in this case, but I didn't think to make them match any specific pattern. https://github.com/GoogleCloudPlatform/google-cloud-python/blob/f034c6121dabfb20cb1cf6b6ae6985b236bfef11/bigquery/google/cloud/bigquery/dbapi/cursor.py#L136
dhermes commentedon Aug 7, 2017
Nice find. Is it worth making it possible to pass in a
job_id(so the system test callers can use something unique)?tswast commentedon Aug 7, 2017
It doesn't fit the DB-API, but yeah I think we need to have some way to introspect.
dhermes commentedon Aug 9, 2017
Another failure: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2825
tswast commentedon Aug 9, 2017
I'll update those tests to set a job ID prefix so it'll be easier to track down.
tswast commentedon Aug 9, 2017
Ah, one thing it could be is the load job may not have finished. I'll use our handy new Futures API to wait until they are done before doing the DML query.
tswast commentedon Aug 9, 2017
The other thing to keep in mind is that I'd very much like to remove the sync query method. Hopefully you got my redesign proposal doc?
lukesneeringer commentedon Aug 10, 2017
I did, but we are in fix-it week so I will not read it until Monday.
tswast commentedon Aug 10, 2017
Unfortunately the query verb doesn't take a job ID, so we'll only be able to debug half the flakes (DB-API, but not sync query). I'll finish my PR for the DB-API part, though.
tswast commentedon Oct 24, 2017
Closing, as I haven't seen this flake on the
bigquery-b2branch and #4245 is now out to merge that to master.