You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Query.next_page() should produce a null cursor if not set on response #1054
I assume you are worried about this line. If the response protobuf doesn't have a value set, we get a None there, right? That seems like the right sentinel to me.
Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of google-cloud-python, I can definitely say that I have let the issues here pile up.
As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.
My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.
Activity
dhermes commentedon Aug 11, 2015
Noticed this during #1055
dhermes commentedon Aug 11, 2015
OK, checking
response.batch.HasField('end_cursor')is alwaysTrue, even when the cursor is''.@tseaver WDYT we should do here? I think returning
''and setting it as the_start_cursorvalue on anIteratoris not the right move.tseaver commentedon Aug 12, 2015
@dhermes While investigating, it just seemed easier to make the change (to ensure I didn't break anything).
dhermes commentedon Aug 12, 2015
No worries.
Merge pull request #1060 from tseaver/1054-nullify_empty_query_cursor
dhermes commentedon Aug 13, 2015
@tseaver Turns out this issue still open.
Remaining concern: Should
Connection.run_querycheck if theend_cursoris set on theresponse.batch?dhermes commentedon Aug 27, 2015
@tseaver Bump
tseaver commentedon Aug 31, 2015
I assume you are worried about this line. If the response protobuf doesn't have a value set, we get a
Nonethere, right? That seems like the right sentinel to me.dhermes commentedon Aug 31, 2015
See what I said above:
lukesneeringer commentedon Aug 11, 2017
Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of
google-cloud-python, I can definitely say that I have let the issues here pile up.As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.
My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.
Thank you!
Remove old parameter enable_word_time_offsets [(#1054)](GoogleCloudPl…
Remove old parameter enable_word_time_offsets [(#1054)](GoogleCloudPl…
Remove old parameter enable_word_time_offsets [(#1054)](GoogleCloudPl…
Remove old parameter enable_word_time_offsets [(#1054)](GoogleCloudPl…
chore: release 0.54.0 (#1054)
chore(main): release 1.11.0 (#1054)
chore(main): release 2.19.1 (#1054)
chore(deps): update all dependencies (#1054)