Repository navigation
chore: set name_pretty_override for all Shopping Merchant libraries - #9698
Merged
quirogas merged 1 commit intoOct 22, 2026
Merged
Conversation
Prevent Librarian from overwriting .repo-metadata.json name_pretty with
the umbrella service title ('Merchant' from merchantapi_v1.yaml) when
generating or regenerating google-shopping-merchant-* packages.
- Add nodejs.name_pretty_override ('Shopping Merchant <Subproduct>') to
all 14 google-shopping-merchant-* entries in librarian.yaml.
- Regenerate all 14 Merchant libraries with Librarian v0.49.0, updating
packages/google-shopping-merchant-loyaltycustomers/.repo-metadata.json
from 'Merchant' to 'Shopping Merchant Loyalty Customers'.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the pretty names for various Google Shopping Merchant API libraries in librarian.yaml by adding the name_pretty_override property. Additionally, it updates the name_pretty field in the repository metadata for the google-shopping-merchant-loyaltycustomers package. There are no review comments, and I have no feedback to provide.
quirogas
marked this pull request as ready for review
October 22, 2026 06:03
quirogas
enabled auto-merge (squash)
October 22, 2026 06:23
suztomo
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configure
name_pretty_overridefor all 14 Shopping Merchant packages inlibrarian.yaml.Impact
Prevents Librarian from overwriting Shopping Merchant
name_prettyvalues with"Merchant".Changes
nodejs.name_pretty_override(Shopping Merchant <Subproduct>) to all 14google-shopping-merchant-*library entries inlibrarian.yamlso Librarian does not default tocleanTitle(api.Title)("Merchant") from the sharedgoogle/shopping/merchant/v1/merchantapi_v1.yamlservice config.google-shopping-merchant-*libraries using the Librarian CLI (v0.49.0), which updatespackages/google-shopping-merchant-loyaltycustomers/.repo-metadata.jsonname_prettyfrom"Merchant"to"Shopping Merchant Loyalty Customers".Testing
librarian tidyandlibrarian install(v0.49.0, Node.jsv22.23.2,pnpm10.34.6).librarian generate <lib>across all 14google-shopping-merchant-*packages."Shopping Merchant <Subproduct>"regenerated with zero diff, andgoogle-shopping-merchant-loyaltycustomers/.repo-metadata.jsonupdated cleanly to"Shopping Merchant Loyalty Customers".Alternatives
.repo-metadata.jsonon every Librarian regeneration or onboarding PR (as in feat(google/shopping/merchant/reviews/v1): onboard a new library #9691) was rejected because weekly API source updates and Librarian version bumps will repeatedly overwritename_prettyback to"Merchant"withoutname_pretty_overrideinlibrarian.yaml.