Repository navigation
chore(librarian): configure package_name for non-cloud libraries - #9321
Merged
Merged
Conversation
…arian to v0.43.0 Update pinned librarian version to v0.43.0 and explicitly set nodejs.package_name for the remaining 8 non-cloud libraries that lacked it: - @google-ads/admanager - @google-ads/datamanager - @google-ai/generativelanguage - @google-analytics/admin - @google-analytics/data - @google-apps/meet - @google-maps/isochrones - @google-shopping/css This prepares google-cloud-node for strict package_name validation in Librarian and eliminates reliance on the legacy 2-dash fallback.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the librarian configuration version to v0.43.0 and adds explicit Node.js package names for several libraries in librarian.yaml, including admanager, datamanager, generativelanguage, admin, data, meet, isochrones, and css. There are no review comments, and I have no feedback to provide.
zhumin8
marked this pull request as ready for review
September 14, 2026 17:36
JoeWang1127
approved these changes
Sep 18, 2026
zhumin8
added a commit
to googleapis/librarian
that referenced
this pull request
Sep 21, 2026
…7634) Derives standard Node.js package names (@google-cloud/<suffix>) during defaults resolution instead of during generator argument construction. The generator now requires nodejs.package_name to be set and fails fast with an explanatory error when it is missing. Non-cloud APIs and custom scopes are populated during library onboarding via custom package prefixes or configured explicitly in librarian.yaml. Moving derivation upstream establishes a single source of truth for the entire generation pipeline and removes redundant runtime guesswork. This is re-apply of #7575, after googleapis/google-cloud-node#9321 is merged. Do not expect generation diff in google-cloud-node. Fixes #7558
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly set nodejs.package_name for the remaining 8 non-cloud libraries that lacked it:
Verified no generation diff introduced by this change.
For googleapis/librarian#7558