Librarian generate diff check failed on main branch

The librarian generate diff check failed on main branch.

To keep the main branch healthy, please consider reverting the triggering change first. Once the revert is merged, you can investigate the failure and submit a new PR with the fix.

Please check the logs: https://github.com/googleapis/google-cloud-node/actions/runs/35003211388

@googleapis/cloud-sdk-librarian-team The workflow failed. Workflow Run: https://github.com/googleapis/google-cloud-node/actions/runs/35003211388

The build failed again. Workflow Run: https://github.com/googleapis/google-cloud-node/actions/runs/35006757261

The build failed again. Workflow Run: https://github.com/googleapis/google-cloud-node/actions/runs/35024107020

The build failed again. Workflow Run: https://github.com/googleapis/google-cloud-node/actions/runs/35033802535

The build failed again. Workflow Run: https://github.com/googleapis/google-cloud-node/actions/runs/35074772852

Root Cause Analysis
The generation check failure on main was introduced by PR #9144 (3ff5ae9), which manually updated .nycrc (removing "text" from reporter) and .gitignore (removing package-lock.json) across packages for the PNPM migration.

Why this caused the failure:

Librarian Templates Divergence: Librarian's Node generator templates (.nycrc.tmpl and .gitignore.tmpl) still define "text" in .nycrc and package-lock.json in .gitignore.
Skipped in PR Check: The PR validation in .github/workflows/generation_check.yaml only runs librarian generate --all when librarian.yaml or the workflow itself is modified (dorny/paths-filter). Because PR chore: update .nycrc, Contributing.md, and .gitignore across packages #9144 only modified package files, librarian generate --all was skipped during PR CI.
Triggered on main: On merge to main, generation_check.yaml runs librarian generate --all unconditionally. Librarian re-templated the packages back to the template state, reverting the manual edits across 477 files and failing git diff --exit-code.

Next Steps
Fix in Librarian: Update the Node generator templates in googleapis/librarian to match the intended changes from #9144 (remove "text" from .nycrc.tmpl and package-lock.json from .gitignore.tmpl).

@bshaffer

After investigating the failure, the relavent templates are within gapic generator. This means if to fix this properly, we need to release a new version of generator to use in librarian.yaml. Note there is librarian#6889, as of now, librarian install only supports pnpm 7.

I think it's best to revert the changes for now to fix main.
I see @bshaffer already have #9354

The build failed again. Workflow Run: https://github.com/googleapis/google-cloud-node/actions/runs/35116161265

#9354 is merged

Navigation Menu

Repository navigation

Librarian generate diff check failed on main branch #9341

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Librarian generate diff check failed on main branch #9341

Description

Activity

github-actions commented on Sep 15, 2026

github-actions commented on Sep 15, 2026

github-actions commented on Sep 15, 2026

github-actions commented on Sep 15, 2026

github-actions commented on Sep 16, 2026

zhumin8 commented on Sep 16, 2026

zhumin8 commented on Sep 16, 2026

github-actions commented on Sep 16, 2026

zhumin8 commented on Sep 16, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions