Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates ImpersonatedCredentials to ensure that if a quota project is configured, it is used for the IAM request when generating an ID token with an audience. It also adds a corresponding unit test to verify that the configured quota project ID correctly overrides the source credentials' quota project ID. I have no feedback to provide as there are no review comments.
afarber
force-pushed
the
12604-impersonated-credentials
branch
from
September 4, 2026 15:41
acda261 to
d253717
Compare
afarber
force-pushed
the
12604-impersonated-credentials
branch
5 times, most recently
from
September 9, 2026 07:14
0e36fd6 to
625c583
Compare
afarber
force-pushed
the
12604-impersonated-credentials
branch
from
September 22, 2026 12:24
625c583 to
431b82d
Compare
afarber
force-pushed
the
12604-impersonated-credentials
branch
from
October 4, 2026 16:51
431b82d to
2b16907
Compare
Author
|
Hi @mutianf why do I received 320 notification mails, even though I have unsubscribed from this PR? 
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the quota project configured on
ImpersonatedCredentialsto IAMgenerateIdTokenrequests.The ID-token path currently uses the source credentials directly, so an impersonated credential's quota-project override is omitted. Use the existing credential metadata mechanism to send the target quota project in the
x-goog-user-projectheader.Adds a regression test verifying that the impersonated credential's quota project overrides the source credential's project.
Fixes #12604