Repository navigation
impl(opentelemetry): replace deprecated semantic convention symbols - #16533
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the gRPC OpenTelemetry span creation to conform to OpenTelemetry RPC semantic conventions by using the fully-qualified logical name for rpc.method, deprecating rpc.service, and transitioning from rpc.system to rpc.system.name. The accompanying unit tests have been updated accordingly. Feedback on the changes suggests replacing the use of auto with an explicit std::string type for the fully_qualified_method variable to comply with the repository's style guide regarding type deduction.
colinmoy
left a comment
There was a problem hiding this comment.
The CI is failing because the new kRpcSystemName constants don't exist in the older opentelemetry-cpp versions in our test matrix. Please use #if macros to maintain backward compatibility
|
Created #16544 to track removal of deprecated constants that have no replacement. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16533 +/- ##
==========================================
- Coverage 92.36% 92.35% -0.01%
==========================================
Files 2262 2262
Lines 217027 217026 -1
==========================================
- Hits 200448 200436 -12
- Misses 16579 16590 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Apparently, semantic conventions come and go across versions of opentelemetry-cpp. In order to avoid deprecated warnings and proliferation of string literals where defined constants exist, this PR introduces a single header file that manages compatibility of these semantic convention symbols. This PR also updates existing usages of string literals to the corresponding constant.