镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

JSpecify incompatibility #904

Closed
Closed

Description

@markusheiden

Describe the bug:
With the 45.0.0 release, some transient libraries were migrated to use JSpecify annotations by simply just adding @NullMarked to the classes.

Steps to Reproduce:

  • Code that implements com.google.auth.oauth2.TokenStore.
  • Code that passes a null baseUri to com.google.auth.oauth2.UserAuthorizer#getAuthorizationUrl or com.google.auth.oauth2.UserAuthorizer#getAndStoreCredentialsFromCode.

Expected behavior:

  • The return value of com.google.auth.oauth2.TokenStore#load value should be @nullable, because null is the expected result for "no token found".
  • The baseUri parameter in com.google.auth.oauth2.UserAuthorizer#getAuthorizationUrl and com.google.auth.oauth2.UserAuthorizer#getAndStoreCredentialsFromCode should be @nullable, because it is just required if using relative callback URIs.
  • JSpecify migration made reasonable by checking what needs @nullable and what does not.

Client library version and API version:
Client library version: 45.0.0
Google Ads API version: 25
JDK version: 26

Activity

  1. jradcliff commented on Aug 20, 2026

    @jradcliff
    Member

    Hi @markusheiden ,

    The Google Ads API library uses the Google Auth libraries, but those are maintained separately in
    the https://github.com/googleapis/google-cloud-java repository so please file an issue there instead. I saw that there are some related issues there already, such as #13708.

    Thanks,
    Josh, Google Ads API Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions