镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

test: Fix Windows Kitchen Sink - #897

Closed
danielbankhead wants to merge 17 commits into
mainfrom
windows-kitchen-sink-fix
Closed

danielbankhead wants to merge 17 commits into
mainfrom
windows-kitchen-sink-fix

Conversation

@danielbankhead

Copy link
Copy Markdown
Contributor

Fixes: #895

@tonycoco tonycoco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danielbankhead pushed a commit that referenced this pull request Oct 10, 2024
danielbankhead added a commit that referenced this pull request Oct 10, 2024
* feat!: Support Node 18+

Drop Support for older versions of Node.js

* chore: skip windows kitchen sink until #897
@tonycoco

Copy link
Copy Markdown
Collaborator

Is this still needed?

@danielbankhead

Copy link
Copy Markdown
Contributor Author

Is this still needed?

Yep, the Windows test has been skipped for now. We should circle back on this one

@d-goog d-goog closed this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Windows system test failing for kitchen sink tests

3 participants