Repository navigation
Bring apitools Python3 support. #1
Description
See @craigcitro comment.
PS Craig, https://github.com/google/protorpc does not have issues turned on.
apitools Python3 support. #1See @craigcitro comment.
PS Craig, https://github.com/google/protorpc does not have issues turned on.
Activity
craigcitro commentedon Feb 26, 2015
@dhermes thanks for the heads-up! fixed.
dhermes commentedon Feb 26, 2015
Filed there too. /cc @tseaver
craigcitro commentedon Feb 28, 2015
quick question for @tseaver: when you applied the
python-modernizechanges to this repo, did you use any special flags?tseaver commentedon Feb 28, 2015
I don't recall any flags (the fixer I wanted to disable was adding
from __future__ import absolute_imports, but I couldn't figure out how).My memory is that I generated a patch file and edited it to remove that import and correct for some other wonkiness.
craigcitro commentedon Mar 1, 2015
OK, we're now much closer: https://pypi.python.org/pypi/google-apitools
i've also done a massive update from internal, and merged in the
gsutilfork. we're unblocked on better py3 support, IIUC.my next step is to move
gsutilover to using this code as a submodule. along those lines, i noticed that one of the changes in 901342e seemed to cause some unicode-related issues when i ran some (still-only-internal) tests; since it's late, i just stripped it out for now, but i think that one might require some digging.dhermes commentedon Mar 2, 2015
w00t
craigcitro commentedon Mar 2, 2015
OK, i made a small effort here in 3c522a4 ... but there's still hard work to be done.
in particular, i need a plan to update or drop
gflagsandapputils. ugh.dhermes commentedon Mar 2, 2015
Drop, drop, drop, drop! Woo hoo!
Make them optional in
setup.pyand then everyone is happy. You can go back to the originold_run.pyinoauth2clientto see how we ditchedgflagsthere. (I think you were part of those code reviews way back when.)dhermes commentedon Mar 24, 2015
@craigcitro Can this be closed? Are
gflagsandapputilsdropped?craigcitro commentedon Mar 25, 2015
So
gflagsandapputilsaren't gone, but i at least have a plan in place. given what you did in #5, i'm gonna close this, and open a new issue to completely drop those dependencies.Merge pull request #1 from benhead/patch-2