Conversation
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
1bf236b to
963cfc1
Compare
|
This PR (HEAD: 963cfc1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/834164. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/834164. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/834164. |
|
Message from Alan Donovan: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/834164. |
Repeated operands add the same instruction to a value's referrer list once per operand. replaceAll currently rescans all operands for every entry, making Phi nodes and similar instructions quadratic.
Group adjacent entries for the same instruction, scan its operands once, and append the original group so referrer multiplicity remains unchanged.
A focused correctness test and benchmark are included. Hosted results (2 CPUs, 1 GiB RAM; median of 3):