Repository navigation
Psso auth methods - #1365
Open
PeshekDotDev wants to merge 14 commits into
Open
Psso auth methods#1365PeshekDotDev wants to merge 14 commits into
PeshekDotDev wants to merge 14 commits into
Conversation
Add a require_biometrics field to RegisterDeviceResponse and have the PSSO bridge set userSecureEnclaveKeyBiometricPolicy to .touchIDOrWatchCurrentSet when the connector requests it.
… key Platform SSO picks the grant from the profile's AuthenticationMethod, so a Password profile needs the password grant advertised or macOS never attempts a login. Advertise both. Registration runs in both modes -- it is what binds the local account to an authentik user -- but only the userSecureEnclaveKey method has a key to register. Thread the method through to RegisterUser and make the key optional instead of force-unwrapping a nil the password mode always produces.
…mented The set is still hardcoded pending a client-rust regeneration, so it is the knob a test run is configured with. Spell out all four members of Apple's OptionSet with the unused ones commented out, so switching configurations does not mean looking the variants up again, and note which combinations conflict.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
- Coverage 42.84% 42.60% -0.25%
==========================================
Files 161 161
Lines 14706 14811 +105
Branches 9721 9760 +39
==========================================
+ Hits 6301 6310 +9
- Misses 8270 8367 +97
+ Partials 135 134 -1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Contributor
|
🚀 Deployed on https://pr-1365--authentik-pkg.netlify.app |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testing
needs goauthentik/authentik#26532 to be merged