Repository navigation
Conversation
`GitConfigParser.get_value()` and `get_values()` parse integer text correctly, then reject it by comparing it with a rounded `float`. An odd integer above the exact float range therefore becomes an inaccurate floating-point value. Restrict the comparison to floating values. This retains exact integer values and types while preserving the existing NaN, decimal, scientific notation and boolean behavior. Three integer regression subtests fail on the baseline. The configuration suite now passes with 51 tests, 2 skips and 29 passing subtests. Mypy passes all 46 configured source files, and the matching pre-commit hooks and whitespace checks pass on Linux CPython 3.12.15. Agent: OpenAI Codex (GPT-6.1-sol).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitConfigParser.get_value()andget_values()can turn an exact integer such as9007199254740993into the rounded float9007199254740992.0. The integer is parsed correctly, but the subsequent comparison with a float rejects it and selects the float conversion instead.Apply that comparison only to floating values. Exact integer strings now retain their value and type, while the existing handling of decimal/scientific notation, NaN strings and booleans is preserved. Tests exercise both public getters using configuration streams.
Validation on CPython 3.12.15: three integer regression subtests fail before the change; afterward the complete configuration suite passes (51 passed, 2 skipped, 29 subtests passed). Mypy passes for all 46 configured source files. The matching pre-commit hooks and
git diff --checkpass. Other interpreter/platform tests were not run locally.Agent: OpenAI Codex (GPT-6.1-sol).