镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix "known" Windows errored test cases #525

Description

@ankostis

Currently, Windows TestCases on Appveyor established on #519 are "artifically" ok.
Because in the code, the Test Cases known to fail on have been marked with the HIDE_WINDOWS_KNOWN_ERRORS variable so that we get an ALL GREEN response; that way we can detect when new commits break additional TCs on Windows.

Currently there are 10 failing TCs (search them with the above var-name), and you can view the errors in this Appveyor job:

https://ci.appveyor.com/project/ankostis/gitpython/build/1.0.196

The errors are mostly related to 2 issues:

  1. Unicode: for those with reading time, I would suggest these 2 contradictory sources:
  2. Leaked resources: these are (possibly memmory-mapped) files that are not deallocated (and hence, not deleted afterwards). Unfortunately, dealing with them might mean that you have to jump projects, as some are inherited from the library projects smmp and (mostly) gitdb.

In order to reproduce the failed TCs on your PC, change locally git/test/lib/helper.py:#L38 from this:

    HIDE_WINDOWS_KNOWN_ERRORS = os.environ.get('HIDE_WINDOWS_KNOWN_ERRORS', True)

into this:

    HIDE_WINDOWS_KNOWN_ERRORS = os.environ.get('HIDE_WINDOWS_KNOWN_ERRORS', False)

This issue is about not forgetting these TCs - asking for help to fix them.

Activity

  1. added 4 commits that reference this issue on Oct 3, 2016
  2. Byron commented on Oct 9, 2016

    @Byron
    Member

    @ankostis Even though I won't be of much help here, I have just provided you with full write permissions on all the gitpython repositories that matter. Previously, I believe you might have been missing write access to smmap, for no other reason than me having forgotten to set it up right away :).

  3. added 6 commits that reference this issue on Oct 11, 2016
  4. 40 remaining items

  5. added 10 commits that reference this issue on Oct 14, 2016
  6. added theissue type on Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions