GitPython does not contain a 'is_valid_hash' method.

Am I missing something or is that currently missing?

The git command would be git cat-file commit {git_hash}.

I used the following before using GitPython:

def git_hash_is_valid(git_hash):
    return subprocess_return_call(f"git cat-file commit {git_hash}") == 0

def subprocess_return_call(call_string):
    call_parameters = call_string.split(" ")
    return subprocess.call(
        call_parameters,
        stderr=subprocess.STDOUT,
        stdout=open(os.devnull, 'w')
    )

Would a method like that fit into repo directly like repo.is_ancestor()?

I know self.repo.commit( works, but that does not differentiate between refs and commit hashes.

PS: If this is something that would be ok to include, I'd create the PR, I'm currently doing it with this:

    def hash_is_valid(self, git_hash):
        try:
            self.repo.commit(git_hash)
        except ValueError:
            return False
        return True

PPS: We could also add default values to the repo.commit( method, to add
SymbolicReferences=True, Commit=True, TagObject=True, Blob=True, Tree=True

Navigation Menu

Repository navigation

GitPython does not contain a 'is_valid_hash' method. #1265

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

GitPython does not contain a 'is_valid_hash' method. #1265

Description

Activity

bytefluxio commented on Jun 4, 2021

bytefluxio commented on Jun 4, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions