镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(a11y): reveal notification actions on keyboard focus - #3647

Open
setchy wants to merge 3 commits into
mainfrom
fix/keyboard-action-visibility
Open

setchy wants to merge 3 commits into
mainfrom
fix/keyboard-action-visibility

Conversation

@setchy

@setchy setchy commented Nov 6, 2026

Copy link
Copy Markdown
Member

Summary

Keyboard navigation could focus notification, repository, and account action buttons while their rail remained invisible: visibility was tied only to mouse hover.

  • Reveal action rails when their row/header contains focus, with the same backdrop used on hover.
  • Hide the notification number while the focused rail is visible, keeping its layout space.
  • Match Glass row/background and focused-icon treatment to the hover state.
  • Add browser checks for focus/blur, backdrop visibility, and notification-number visibility across Classic/Glass light and dark.

Verification

  • pnpm check passed.
  • pnpm test passed: 219 files, 2,189 tests.
  • pnpm build passed.
  • Pre-commit lint, formatting, type-checking, and affected tests passed.
  • Browser/visual verification is pending the Linux CI job; Docker is not running locally.

Intended as a patch-level usability fix.

@setchy
setchy requested a review from afonsojramos as a code owner November 6, 2026 01:00
@github-actions github-actions Bot added the bug Something isn't working label Nov 6, 2026
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

1 participant