镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Add generic collaborative visual decision cards - #417

Draft
MaggieAppleton wants to merge 8 commits into
mainfrom
maggie/generic-visual-decision-runtime
Draft

MaggieAppleton wants to merge 8 commits into
mainfrom
maggie/generic-visual-decision-runtime

Conversation

@MaggieAppleton

@MaggieAppleton MaggieAppleton commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add a generic visual-decision@1 contract with bounded numeric and colour controls, immutable definition and artifact revisions, shared edits, and durable version-bound Save.
  • Render the same decision card for different components. Verify isolated preview bundles before loading them in an opaque iframe, and enable Save only after the current parameters are acknowledged.
  • Cover two distinct component fixtures, concurrent edits, stale and rolled-back Save, reload, baseline peek, and read-only access in real browser tests.

Actual UI

A saved Billing card and an editable Profile banner using the same visual decision card

Verification

At c7a7f905383b3638ed9a355729954a8831890d2d, current main (dce9a4fa3d9a0e264c162528746271b31d6ae5db) is merged without rewriting #417. The only direct conflicts were adjacent route additions: this PR's authenticated visual preview route and main's GitHub reference route. Both remain registered. Local bun run ci, bun run types, bun run build, and 79 focused server/editor tests passed. Exact-head CI validation, PostgreSQL tests, browser E2E, and container build passed. The earlier head also passed four PostgreSQL-backed visual-decision browser scenarios.

Integration boundary

VisualDecisions.create() is an internal server function that requires a trusted artifact verifier. This PR adds no hosted Planner creation tool, durable pending-request API, publication pickup, production artifact resolver, or MCP saved-result readback. The two bundle resolvers are test-only; without a trusted production resolver, existing cards show Preview unavailable and cannot be saved.

@coolify-githubnext-app

coolify-githubnext-app Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The preview deployment for chopin is ready. 🟢

Open app | Open Build Logs | Open Application Logs

Last updated at: 2026-10-09 14:25:32 CET

@MaggieAppleton
MaggieAppleton marked this pull request as ready for review October 9, 2026 11:22
@MaggieAppleton
MaggieAppleton marked this pull request as draft October 9, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant