镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

[python] TarSlip vulnerability improvements #710

Closed

Description

@Sim4n6

Query PR

github/codeql#10851 (closed in favor of the next one)
github/codeql#10887

Language

Python

CVE(s) ID list

CWE

CWE-022

Report

  1. TarSlip vulnerability.
  2. _Extracting files from a malicious tarball without validating that the destination file path is within the destination directory can cause files outside the destination directory to be overwritten, due to the possible presence of directory traversal elements (..) in archive path names.
  3. I have added more sources and sinks than I checked the combination use of both.
  4. Yes, I've checked the query against valid samples extracted from https://github.com/proxy/cs.github.com/. I ethically reported them using https://huntr.dev (more to become public soon).
  5. This is my first contribution, and I would love to provide more.

Are you planning to discuss this vulnerability submission publicly? (Blog Post, social networks, etc).

  • Yes
  • No

Blog post link

https://www.getrevue.co/profile/sim4n6

#710 (comment)

Activity

  1. added
    All For OneSubmissions to the All for One, One for All bounty
    on Oct 16, 2022
  2. ghsecuritylab commented on Oct 17, 2022

    @ghsecuritylab
    Collaborator

    Your submission is now in status Test run.

    For information, the evaluation workflow is the following:
    Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

  3. ghsecuritylab commented on Oct 18, 2022

    @ghsecuritylab
    Collaborator

    Your submission is now in status Query review.

    For information, the evaluation workflow is the following:
    Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

  4. ghsecuritylab commented on Oct 18, 2022

    @ghsecuritylab
    Collaborator

    Your submission is now in status Results analysis.

    For information, the evaluation workflow is the following:
    Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

  5. Sim4n6 commented on Oct 19, 2022

    @Sim4n6
    Author

    Re-adapted the PR into this one: github/codeql#10887

  6. Sim4n6 commented on Oct 25, 2022

    @Sim4n6
    Author

    PR merged github/codeql#10887 💯

  7. Sim4n6 commented on Nov 10, 2022

    @Sim4n6
    Author

    Any update related to this issue, please? 🙃

  8. JarLob commented on Nov 10, 2022

    @JarLob
    Contributor

    Hi @Sim4n6,
    Sorry that it takes so long. As I see it is very close to resolution. Unfortunately GitHub Universe 2022 may delay the final step for few days more. I'll ping people and maybe it will be resolved sooner.

  9. ghsecuritylab commented on Nov 10, 2022

    @ghsecuritylab
    Collaborator

    Your submission is now in status Final decision.

    For information, the evaluation workflow is the following:
    Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

  10. xcorail commented on Nov 15, 2022

    @xcorail
    Contributor

    Hello @Sim4n6
    Can you please provide a public email address, or send me privately a private one?
    Thanks

  11. ghsecuritylab commented on Nov 15, 2022

    @ghsecuritylab
    Collaborator

    Your submission is now in status Pay.

    For information, the evaluation workflow is the following:
    Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

  12. Sim4n6 commented on Nov 15, 2022

    @Sim4n6
    Author
  13. xcorail commented on Nov 16, 2022

    @xcorail
    Contributor

    Created Hackerone report 1775224 for bounty 438181 : [710] [python] TarSlip vulnerability improvements

  14. ghsecuritylab commented on Nov 16, 2022

    @ghsecuritylab
    Collaborator

    Your submission is now in status Closed.

    For information, the evaluation workflow is the following:
    Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

  15. Sim4n6 commented on Nov 16, 2022

    @Sim4n6
    Author

    Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    All For OneSubmissions to the All for One, One for All bounty

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions