Repository navigation
Conversation
bb-app and @get-bb/plugin-sdk had no license field and shipped no LICENSE file, so license audits reported them as unknown. Add "license": "MIT" to both manifests and a copy of the repository LICENSE to each package root, which npm always packs. Fixes get-bb#6662
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
packages/bb-app/package.jsonandpackages/plugin-sdk/package.jsonhave nolicensefield, and neither package directory has aLICENSEfile. The publishedbb-appand@get-bb/plugin-sdktarballs therefore have no license metadata or notice, and license audits report them as unknown, although the repository is MIT (#6662).What changed
packages/bb-app/package.jsonandpackages/plugin-sdk/package.json: add"license": "MIT"afterversion.packages/bb-app/LICENSEandpackages/plugin-sdk/LICENSE: copies of the repositoryLICENSE, byte for byte. npm always packsLICENSEfrom the package root, whatever thefileslist is.@get-bb/plugin-sdkneeds no version bump: 0.6.140 is not on npm yet (the latest is 0.6.138), so the next publish ships this content. Thebb-appprepackstep prunes onlybb-chunksand keepsLICENSE.No wire, CLI or runtime change.
How you verified
npm pack --dry-run --json --ignore-scriptsin each package directory listsLICENSEin both tarballs.node packages/plugin-sdk/scripts/check-npm-version-guard.mjs:PASS — @get-bb/plugin-sdk@0.6.140 is not on npm yet.pnpm exec turbo run test lint --filter=@get-bb/plugin-sdk --filter=bb-apppasses: 7 of 7 tasks, 35 and 23 test files.oxfmt --checkpasses on both manifests.cmpshows that both copies are identical to the repositoryLICENSE.Fixes #6662