镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Release 5.0.0 not available in sub projects #1241

Closed

Description

@acbramley

I'm working on upgrading to PHP 8.4 and currently 4.7.1 has a lot of deprecations due to implicit nullables. All of these are fixed in HEAD and by the looks of the other changes, it's mostly PHPCS/vanity stuff. It would be great to get a new stable release for sites to upgrade to using PHP 8.4

geocoder-php/google-maps-provider@4.7.1...master

Activity

  1. steffans commented on Jan 28, 2025

    @steffans

    Yes, would be also nice to have the 8.4 fixes released for geocoder-php/geoip2-provider 🙏

  2. acbramley commented on Mar 4, 2025

    @acbramley
    Author

    5.0.0 is released but it doesn't seem to have propagated to the subtree splits e.g geocoder-php/google-maps-provider still only has a 4.7.1 release.

  3. changed the title [-]Release 4.8.0?[/-] [+]Release 5.0.0 not available in sub projects[/+] on Apr 15, 2025
  4. acbramley commented on Apr 15, 2025

    @acbramley
    Author

    @jbelien are you able to see why we can't upgrade to 5.0.0 for the sub projects that are built off this repo? E.g https://packagist.org/packages/geocoder-php/google-maps-provider

  5. jbelien commented on Apr 15, 2025

    @jbelien
    Member

    I'll have a look!

    composer.json seems to allow version 5:

    "willdurand/geocoder": "^4.0|^5.0"

    There might be a conflict with another library. I'll check 👍

  6. jbelien commented on Apr 15, 2025

    @jbelien
    Member

    5.0.0 is released but it doesn't seem to have propagated to the subtree splits e.g geocoder-php/google-maps-provider still only has a 4.7.1 release.

    There is no relation between the release number of a provider and the release number of the "main" package!
    Version 4.7.1 of Google Maps provider does support version 5.0.0 of our "main" package (see previous comment).

  7. norkunas commented on Apr 15, 2025

    @norkunas
    Member
  8. jbelien commented on Apr 15, 2025

    @jbelien
    Member

    Issue confirmed!

    $ composer require geocoder-php/google-maps-provider guzzlehttp/guzzle
    
    ...
    Installing dependencies from lock file (including require-dev)
    Package operations: 12 installs, 0 updates, 0 removals
      - Downloading php-http/discovery (1.20.0)
      - Downloading willdurand/geocoder (4.6.0)
      - Downloading guzzlehttp/psr7 (2.7.1)
      - Downloading symfony/deprecation-contracts (v3.5.1)
      - Downloading guzzlehttp/promises (2.2.0)
      - Downloading guzzlehttp/guzzle (7.9.3)
      - Downloading geocoder-php/common-http (4.6.0)
      - Downloading geocoder-php/google-maps-provider (4.7.1)
    ...

    We indeed forgot to create a new release for the providers. The composer.json file is up-to-date but no release was created for most of the providers.
    And we need to start with geocoder-php/common-http.

    I'll take care of it now! 👍

  9. jbelien commented on Apr 15, 2025

    @jbelien
    Member
    • Common HTTP: geocoder-php/common-http
    • Cache: geocoder-php/cache-provider
    • Chain: geocoder-php/chain-provider
    • AlgoliaPlaces: geocoder-php/algolia-places-provider
    • ArcGISOnline: geocoder-php/arcgis-online-provider
    • AzureMaps: geocoder-php/azure-maps-provider
    • BingMaps: geocoder-php/bing-maps-provider
    • FreeGeoIp: geocoder-php/free-geoip-provider
    • GeoIP2: geocoder-php/geoip2-provider
    • GeoPlugin: geocoder-php/geo-plugin-provider
    • GeocodeEarth: geocoder-php/geocode-earth-provider
    • Geonames: geocoder-php/geonames-provider
    • GoogleMaps: geocoder-php/google-maps-provider
    • GoogleMapsPlaces: geocoder-php/google-maps-places-provider
    • GraphHopper: geocoder-php/graphhopper-provider
    • Here: geocoder-php/here-provider
    • HostIp: geocoder-php/host-ip-provider
    • IP2Location: geocoder-php/ip2location-provider
    • IP2LocationBinary: geocoder-php/ip2location-binary-provider
    • IpInfo: geocoder-php/ip-info-provider
    • IpInfoDb: geocoder-php/ip-info-db-provider
    • Ipstack: geocoder-php/ipstack-provider
    • LocationIQ: geocoder-php/locationiq-provider
    • MapQuest: geocoder-php/mapquest-provider
    • MapTiler: geocoder-php/maptiler-provider
    • Mapbox: geocoder-php/mapbox-provider
    • MaxMind: geocoder-php/maxmind-provider
    • MaxMindBinary: geocoder-php/maxmind-binary-provider
    • Nominatim: geocoder-php/nominatim-provider
    • OpenCage: geocoder-php/open-cage-provider
    • OpenRouteService: geocoder-php/openrouteservice-provider
    • Pelias: geocoder-php/pelias-provider
    • Photon: geocoder-php/photon-provider
    • PickPoint: geocoder-php/pickpoint-provider
    • TomTom: geocoder-php/tomtom-provider
    • Yandex: geocoder-php/yandex-provider
  10. jbelien commented on Apr 15, 2025

    @jbelien
    Member

    Should now be good for geocoder-php/google-maps-provider! 👍
    I'll take care of all providers in the next few days.


    Seems to work indeed!

    Loading composer repositories with package information
    Updating dependencies
    Lock file operations: 0 installs, 2 updates, 0 removals
      - Upgrading geocoder-php/common-http (4.6.0 => 4.7.0)
      - Upgrading willdurand/geocoder (4.6.0 => 5.0.0)
  11. acbramley commented on Apr 15, 2025

    @acbramley
    Author
    ❯ composer require geocoder-php/google-maps-provider:^4.8 -W
    ./composer.json has been updated
    Running composer update geocoder-php/google-maps-provider --with-all-dependencies
    Gathering patches from patch file.
    Loading composer repositories with package information
    Updating dependencies
    Lock file operations: 0 installs, 3 updates, 0 removals
      - Upgrading geocoder-php/common-http (4.6.0 => 4.7.0)
      - Upgrading geocoder-php/google-maps-provider (4.7.1 => 4.8.0)
      - Upgrading willdurand/geocoder (4.6.0 => 5.0.0)
    

    Amazing, thanks @jbelien!

  12. jbelien commented on Apr 16, 2025

    @jbelien
    Member

    All "address providers" have been released.
    I'll take care of all "IP providers" a bit later.

  13. jbelien commented on Apr 16, 2025

    @jbelien
    Member

    All providers have been released!

  14. norkunas commented on Apr 30, 2025

    @norkunas
    Member

    @jbelien it still blocks to install willdurand/geocoder v5 for BazingaGeocoderBundle as it requires https://github.com/geocoder-php/plugin which did not get new release

  15. reopened this on May 1, 2025
  16. jbelien commented on May 1, 2025

    @jbelien
    Member

    Sorry, I indeed forgot geocoder-php/plugin.
    I'll try to take care of it in the next few days.

  17. norkunas commented on May 1, 2025

    @norkunas
    Member

    Thank you

  18. norkunas commented on May 10, 2025

    @norkunas
    Member

    @jbelien just wanted to remind you :)

  19. jbelien commented on May 17, 2025

    @jbelien
    Member

    @jbelien it still blocks to install willdurand/geocoder v5 for BazingaGeocoderBundle as it requires https://github.com/geocoder-php/plugin which did not get new release

    ✅ Done! https://github.com/geocoder-php/plugin/releases/tag/1.6.0

  20. norkunas commented on May 17, 2025

    @norkunas
    Member

    Thank you!

  21. apollmeier commented on Jun 3, 2025

    @apollmeier

    I would like to add the MapTiler provider. The upgrade to Geocoder v5 is in the main repository, but this has not yet been reflected in the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions