镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

[v3] Database#on is not supporting cancel callbacks #91

Open
Open
[v3] Database#on is not supporting cancel callbacks#91
Assignees
auser
Labels
bug
Milestone
v3

Description

@pedro-ribeiro
pedro-ribeiro
opened on Oct 27, 2016

Database#on is not supporting setting cancel callbacks. This makes it impossible to deal with Permission Denied errors.

Currently, on error the library will simply log the error message. (https://github.com/fullstackreact/react-native-firestack/blob/master/lib/modules/database.js#L401)

See Firebase documentation.

Activity

  1. auser commented on Oct 27, 2016

    @auser
    auser
    on Oct 27, 2016
    Contributor

    Mmm good catch. I must have left this on the TODO. Think we should just throw a JS event back on errors?

  2. pedro-ribeiro commented on Oct 27, 2016

    @pedro-ribeiro
    pedro-ribeiro
    on Oct 27, 2016
    ContributorAuthor

    In my opinion, it should mimic as much as possible the firebase js sdk.

  3. auser
    self-assigned this
    on Nov 9, 2016
  4. auser
    added
    bug
    on Nov 9, 2016
  5. Salakar
    added this to the v3 milestone on Nov 23, 2016
  6. Salakar
    changed the title [-]Database#on is not supporting cancel callbacks[/-] [+][v3] Database#on is not supporting cancel callbacks[/+] on Nov 23, 2016

  7. janvogt commented on Nov 28, 2016

    @janvogt
    janvogt
    on Nov 28, 2016
    Contributor

    +1
    Need this too. Relevant documentation is https://firebase.google.com/docs/reference/js/firebase.database.Reference#on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bug

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions