镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

[v3] Is it possible to remove unnecessary dependencies from Podfile? #160

Open

Description

@rohitgoyal

Hi
Basically I just want to use the Firebase Analytics which would just require Firebase and Firebase.Core dependencies as far as i know.
I am never gonna use Firebase database/Auth/RemoteConfig for sure. Now these dependencies would be taking unnecessary space in my app.

I tried removing the unnecessary pods and running pod install. But the build is failing after that show errors for FirebaseAuth etc.
Is there any way to avoid this?

Activity

  1. Salakar commented on Nov 23, 2016

    @Salakar
    Collaborator

    @auser @chrisbianca reckon it'd be possible to do this ios side, only load the RN modules we have the SDK's for? As far as I remember it should be doable android wise?

    But then it's an extra setup step I guess to add FB SDK's

    Thoughts?

  2. chrisbianca commented on Nov 23, 2016

    @chrisbianca
    Contributor

    @Salakar this is probably stretching my knowledge of iOS a little far.

    I guess the normal way to resolve this would be to break Firestack into different packages (similar to how Firebase is) but that defeats some of the point of having it nicely centralised.

  3. rohitgoyal commented on Nov 23, 2016

    @rohitgoyal
    Author

    @chrisbianca Analytics and Ads would be 2 category that would be used in far greater numbers than the rest of the functionalities of Firebase I guess.

  4. Salakar commented on Nov 23, 2016

    @Salakar
    Collaborator

    but that defeats some of the point of having it nicely centralised.

    @chrisbianca very true, does bloat it however - for example ads is a big one and has a ton of sub modules, rn views etc - deffo think this should be separate if we get round to implementing it, as @rohitgoyal said.

    Think the rest then just remain part of core I guess? Come to think of it now I don't think there'd be any way to do this within the same repo as you said @chrisbianca. JS side it'd be easy with dynamic modules imports etc, but... you can't do that on the native side (at least without a ton of work - i.e android optional modules/submodules)

    @auser @Ehesp @BlooJeans thoughts?

  5. auser commented on Nov 23, 2016

    @auser
    Contributor

    It should be doable on iOS, actually. I can get to implementing that on iOS this weekend.

  6. auser commented on Nov 23, 2016

    @auser
    Contributor

    it might also be possible to do it entirely on the JS side and only require modules as they are required through the JS API.

  7. Salakar commented on Nov 23, 2016

    @Salakar
    Collaborator

    @auser this will still get compiled by gradle for example though, its the individual firebase SDKs that need to be optional really

  8. auser commented on Nov 23, 2016

    @auser
    Contributor

    Mmm good point. We should be able to handle it on iOS. I'll explore a few thoughts tomorrow. I think we can handle it with an #ifdef clause

  9. added this to the v3 milestone on Dec 29, 2016
  10. changed the title [-]Is it possible to remove unnecessary dependencies from Podfile?[/-] [+][v3] Is it possible to remove unnecessary dependencies from Podfile?[/+] on Dec 29, 2016
  11. Salakar commented on Dec 29, 2016

    @Salakar
    Collaborator

    @auser any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions