镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

Storage "upload" method do not save metadata on Android #141

Closed
Closed
Storage "upload" method do not save metadata on Android#141

Description

@Yarikx
Yarikx
opened on Nov 17, 2016

Metadata is not propagated to native code.

https://github.com/fullstackreact/react-native-firestack/blob/master/android/src/main/java/io/fullstack/firestack/FirestackStorage.java#L157
Metadata map is destructured but never used.

Activity

  1. Salakar commented on Nov 17, 2016

    @Salakar
    Salakar
    on Nov 17, 2016
    Collaborator

    @Yarikx will sort on my branch (which is going to be merged for v3)

  2. Yarikx commented on Nov 17, 2016

    @Yarikx
    Yarikx
    on Nov 17, 2016
    Author

    @Salakar Cool!

  3. Salakar
    added a commit that references this issue on Nov 17, 2016

    fixes fullstackreact#141

    5968ee1

  4. Salakar commented on Nov 17, 2016

    @Salakar
    Salakar
    on Nov 17, 2016
    Collaborator

    Done, on my branch.

  5. auser commented on Nov 17, 2016

    @auser
    auser
    on Nov 17, 2016
    Contributor

    Looking forward to merge this -- working on tests

  6. Salakar commented on Nov 19, 2016

    @Salakar
    Salakar
    on Nov 19, 2016
    Collaborator

    Closing as fixed on v3 branch.

  7. Salakar
    closed this as completedon Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions