Repository navigation
[Android] Don't hard set play services version #134
Description
Hello,
Bear in mind, I'm not to clued up to Android yet...
I keep running into the same issue whereby my build fails due to "Multiple dex files". The cause of this is conflicting play-services versions across multiple libs. This library hard sets the dep to 9.8.0.
Other libs seem to only set it to "whatever is latest", e.g: https://github.com/zo0r/react-native-push-notification/blob/master/android/build.gradle#L44 & https://github.com/idehub/react-native-google-analytics-bridge/blob/master/android/build.gradle#L21
The only way I can fix these errors is by either:
- Adding this to my own build.gradle:
dependencies {
compile ('com.google.android.gms:play-services-gcm:9.8.0') {
force = true;
}
...
- Going into node_modules, and changing the line to
compile 'com.google.android.gms:play-services-base:+'.
Didn't want to make a PR since I'm not sure if this will have any repercussions?
Activity
auser commentedon Nov 15, 2016
That should be fine. Make a PR when you get a chance. I think that sounds like a great idea.
@Ehesp ^^
auser commentedon Nov 16, 2016
Actually, what do you think about doing this for all Firestack dependencies?
Ehesp commentedon Nov 16, 2016
I supposed the only issue is if the lib isn't kept up to date with say the latest firebase SDK, then users are going to have weird issues.
auser commentedon Nov 17, 2016
Good point. I agree.
Don't hard set Android play services version fullstackreact#134
Salakar commentedon Nov 19, 2016
Closing as fixed on v3 branch.
Merge pull request #146 from Ehesp/patch-2