Keep the right-hand side of an exception abbreviation - #3513
Merged
Merged
Conversation
`exception MyError = System.Exception` was formatted as `exception MyError`, which silently declares a new exception instead of abbreviating an existing one. ASTTransformer dropped the abbreviated name that SynExceptionDefnRepr carries, in implementation and signature files alike. ExceptionDefnNode now holds it, and CodePrinter prints it after the case and before any `with` members. Adding that field changes a public Oak constructor, which is allowed in any release. The docs now say so in every place a reader of the Oak lands: a standing section in the upgrade guide replaces the v8 Oak change lists and shows how to diff SyntaxOak.fs between release tags, and GeneratingCode, the SyntaxOak module doc, the pull request ground rules and AGENTS.md all point the same way. Fixes fsprojects#3511
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exception MyError = System.Exceptionwas formatted asexception MyError, which silently declares a new exception instead of abbreviating an existing one. ASTTransformer dropped the abbreviated name that SynExceptionDefnRepr carries, in implementation and signature files alike. ExceptionDefnNode now holds it, and CodePrinter prints it after the case and before anywithmembers.Adding that field changes a public Oak constructor, which is allowed in any release. The docs now say so in every place a reader of the Oak lands: a standing section in the upgrade guide replaces the v8 Oak change lists and shows how to diff SyntaxOak.fs between release tags, and GeneratingCode, the SyntaxOak module doc, the pull request ground rules and AGENTS.md all point the same way.
Fixes #3511