镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

flat-manager-client should reattach to an in-progress job rather than failing #7

Open

Description

@abderrahim

After being killed (for instance because of #2) running flat-manager-client with --wait complains the the build is already committed even though the commit is still in progress.

It would be nice if it could still wait for the running job to finish (and if possible, print its output).

Activity

  1. nanonyme commented on Mar 3, 2019

    @nanonyme
    Contributor

    If this behaviour isn't 1:1 desirable for Flathub app builds, there could always be a separate parameter for us to use.

  2. alexlarsson commented on Mar 4, 2019

    @alexlarsson
    Member

    I don't think re-running it the same way and doing something else is right, but we should have a way to just connect to and wait for a running job.

  3. nanonyme commented on Mar 4, 2019

    @nanonyme
    Contributor

    How do we know though if the commit succeeds or not if backend may return garbage?

  4. alexlarsson commented on Mar 4, 2019

    @alexlarsson
    Member

    Well, the garbage response is just a temporary network issue. You can reconnect to the service and get the status of the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions