镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

update auth deployment to use any existing app - #11273

Merged
aalej merged 3 commits into
mainfrom
aalej_fix-11250
Oct 14, 2026
Merged

update auth deployment to use any existing app#11273
aalej merged 3 commits into
mainfrom
aalej_fix-11250

Conversation

@aalej

@aalej aalej commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #11250

Scenarios Tested

Test on a project with only an Android app - ok

  • Deployment sets up correctly
$ firebase deploy --only auth --project tools-11250-5-android

=== Deploying to 'tools-11250-5-android'...

i  deploying auth
Enabling auth providers: anonymous, email/password, Google sign-in...
✔  Auth providers enabled: anonymous, email/password, Google sign-in

✔  Deploy complete!

Project Console: https://console.firebase.google.com/project/tools-11250-5-android/overview

Test on a project with only an iOS app - ok

  • Deployment sets up correctly
$ firebase deploy --only auth --project tools-11250-5-ios

=== Deploying to 'tools-11250-5-ios'...

i  deploying auth
Enabling auth providers: anonymous, email/password, Google sign-in...
✔  Auth providers enabled: anonymous, email/password, Google sign-in

✔  Deploy complete!

Project Console: https://console.firebase.google.com/project/tools-11250-5-ios/overview

Test on a project with only a Web app - ok

  • Deployments sets up correctly
$ firebase deploy --only auth --project tools-11250-5-web

=== Deploying to 'tools-11250-5-web'...

i  deploying auth
Enabling auth providers: anonymous, email/password, Google sign-in...
✔  Auth providers enabled: anonymous, email/password, Google sign-in

✔  Deploy complete!

Project Console: https://console.firebase.google.com/project/tools-11250-5-web/overview

Test on a project with no app - ok

  • Deployments set up correctly
$ firebase deploy --only auth --project tools-11250-5-no-app

=== Deploying to 'tools-11250-5-no-app'...

i  deploying auth
No Firebase App found. Creating 'Default Web App' for Auth provisioning...
Enabling auth providers: anonymous, email/password, Google sign-in...
✔  Auth providers enabled: anonymous, email/password, Google sign-in

✔  Deploy complete!

Project Console: https://console.firebase.google.com/project/tools-11250-5-no-app/overview

Sample Commands

firebase deploy --only auth

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 13, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Auth deployment process to search for and use existing Firebase apps across any platform (including iOS and Android) before creating a new 'Default Web App'. Feedback on these changes suggests defensively filtering the platform passed to the provisioning API to ensure only valid deployment platforms (IOS, ANDROID, or WEB) are used, and prioritizing other existing Web apps over mobile apps when the 'Default Web App' is not found.

Comment thread src/deploy/auth/deploy.ts Resolved
Comment thread src/deploy/auth/prepare.ts Resolved
joehan
joehan reviewed Oct 13, 2026
View reviewed changes

@joehan joehan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but definitely double check this for ios to make sure it works across paltforms. I know android and web are used in AI studio with this endpoint, but idk if ios is used anywhere

Comment thread CHANGELOG.md Outdated
- Fixed a race condition in `SourceTokenScraper` that could cause concurrent function deployments to hang when refreshing an expired source token (#6989).
- Fixed an issue where a Function Kit and a functions codebase sharing the same source directory failed `firebase.json` validation. (#11253)
- Fixed an issue where Cloud Functions creation did not retry on HTTP 403 service account propagation errors. (#11251)
- Updated Auth deployment to use existing apps from any platform before creating a Default Web App. (#11250)

@joehan joehan Oct 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Updated Auth deployment to use existing apps from any platform before creating a Default Web App. (#11250)
- Updated Auth deployment to use existing apps from any platform before creating a default web app. (#11250)

joehan
joehan approved these changes Oct 13, 2026
View reviewed changes

@joehan joehan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but definitely double check this for ios to make sure it works across paltforms. I know android and web are used in AI studio with this endpoint, but idk if ios is used anywhere

@aalej
aalej enabled auto-merge (squash) October 14, 2026 12:03
@aalej

aalej commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review! Confirmed that deployments with only an ios app available on the project works

@aalej
aalej merged commit a289497 into main Oct 14, 2026
51 checks passed
@aalej
aalej deleted the aalej_fix-11250 branch October 14, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joehan joehan joehan approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

deploy --only auth creates a "Default Web App" in a project with only Android and iOS apps

2 participants

@aalej @joehan